Use wp_rand() for multisite admin email confirmation token generation#12230
Use wp_rand() for multisite admin email confirmation token generation#12230tanjiroK-coder wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tanjiroK-coder. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Completes the hardening from #43771, which replaced mt_rand() with the CSPRNG-backed wp_rand() for email-change confirmation tokens in update_option_new_admin_email() and send_confirmation_on_profile_email(), but missed the multisite equivalent update_network_option_new_admin_email().
tanjiroK-coder
force-pushed
the
multisite-admin-email-token-wp-rand
branch
from
791f8ee to
e4ae050
Compare
|
any update on this? |
|
Hey @tanjiroK-coder I cannot progress this any further, what would help is a related trac ticket, as this would actually help the progress. There might be an umbrella ticket for general modernization. cc @westonruter |
2 participants
Replace
mt_rand()withwp_rand()when generating the confirmation token inupdate_network_option_new_admin_email().This aligns multisite behavior with the security hardening previously applied to similar email-change confirmation flows in core.
Background
The confirmation token is currently generated using:
While the token includes additional inputs,
mt_rand()is not intended for security-sensitive randomness.WordPress previously hardened similar email-change confirmation token generation by replacing
mt_rand()withwp_rand()in:update_option_new_admin_email()send_confirmation_on_profile_email()This change applies the same approach to the multisite/network equivalent function, ensuring consistency across all email-change confirmation workflows.
Changes
Testing
wp_rand()is available when the hook executes.